website icon indicating copy to clipboard operation
website copied to clipboard

feat: create SetWebhookUtil component

Open roziscoding opened this issue 3 years ago • 6 comments

Preview:

image image image image

Closes #517

roziscoding avatar Oct 09 '22 17:10 roziscoding

Would you be able to defer loading everything until hydration kicks in, using a dynamic import? I'm not sure it's a good idea to bundle the component framework and grammY and everything else into the static site, this will add a few hundred kB to the build.

The component is usually at the very bottom of the page, so in 99 % of page visits, we have a few minutes to download the extra weight and render the component.

Yes, this will mean that the component doesn't load if JS is disabled, but this actually makes a lot of sense anyway.

KnorpelSenf avatar Oct 10 '22 05:10 KnorpelSenf

This does not target bullet points 2 and 5 from #517 yet, but is generally ready for review. I'll cover those points later this week.

Translation files:

  • es-ES: site/docs/.vuepress/components/set-webhook-util/translations/es-ES.ts
  • id: site/docs/.vuepress/components/set-webhook-util/translations/id.ts
  • zh-CN: site/docs/.vuepress/components/set-webhook-util/translations/zh-CN.ts

Localized Pages:

  • es-ES: site/docs/es/webhook-util.md
  • id: site/docs/id/webhook-util.md
  • zh-CN: site/docs/zh/webhook-util.md

roziscoding avatar Oct 17 '22 15:10 roziscoding

All features are now implemented. The build fails locally because I didn't use the CDN version of grammY. I'll need some help getting that done. Once I can build a production version, I can test possible performance improvements.

roziscoding avatar Oct 19 '22 02:10 roziscoding

It looks like it OOMs?

KnorpelSenf avatar Oct 19 '22 05:10 KnorpelSenf

I can take a closer look at a later point

KnorpelSenf avatar Oct 19 '22 05:10 KnorpelSenf

It looks like it OOMs?

Yeah, in github actions it fails due to OOM, but locally the error is different. I'll post it here in about an hour when I get to the computer.

roziscoding avatar Oct 19 '22 11:10 roziscoding

Closing this in favor of https://github.com/grammyjs/website/pull/633

roziscoding avatar Feb 26 '23 21:02 roziscoding