omniconf icon indicating copy to clipboard operation
omniconf copied to clipboard

Questionmark is not a valid character in environment variables

Open lenaschoenburg opened this issue 7 years ago • 3 comments

Question marks are not allowed in environment variables but are valid keywords in clojure. We should escape question mark to something (maybe _Q_) and use that as the variable name.

lenaschoenburg avatar Jul 12 '17 12:07 lenaschoenburg

This is a good point. However, if we are to go this way I prefer making a comprehensive munging/unmunging suite for each config source (env, cli opts, etc.), not just limit ourselves to question mark. What do you think?

alexander-yakushev avatar Jul 12 '17 12:07 alexander-yakushev

Agreed. I wonder if the clojure source code contains some code for this already? For munging function names in exceptions etc.

lenaschoenburg avatar Jul 12 '17 13:07 lenaschoenburg

There is munging, but it is for making Clojure literals Java (JVM) friendly. We'll need custom munging/unmunging for our purposes.

alexander-yakushev avatar Jul 12 '17 18:07 alexander-yakushev