gramineproject
Add support for CentOS Stream 9
Description of the changes
Add support for CentOS Stream 9 using the image - quay.io/centos/centos:stream9 to GSC.
How to test this PR?
To test this PR, set follow similar procedure as followed with Ubuntu and do gsc build and signing commands.
This change is 
config.yaml.template line 9 at r1 (raw file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
It looks like there is no official CentOS Stream 9 on DockerHub? Interesting. Do you know the reason for this? (All other base OS images we pull from DockerHub.)
Yes, this is true. There is no official image for CentOS Stream 9, so I use the community-based image for CentOS Stream 9.
@dimakuv @jkr0103 In this 32b4a96619964f3cd640302f13c9d317d98f0bcf commit, I have created a folder under CentOS called "stream". Now, all 5 Dockerfiles are located here, instead of quay.io/centos/centos. This eliminates the need to create extra folders for CentOS releases.
templates/quay.io/centos/centos/Dockerfile.build.template line 15 at r4 (raw file):
Previously, adarshan-intel (Adarsh Anand) wrote…
Can you suggest what can I do here, since removing this package shows this error? Not sure how to fix it
If I install the "which" package, the build will be successful. As earlier it was not able to execute the command
which /bin/bash
Previously, adarshan-intel (Adarsh Anand) wrote…
Yes, fixed the issue by installing protobuf-c-compiler, java-11-openjdk, java-11-openjdk-devel packages
@dimakuv Is this still blocking? I have installed the which, protobuf-c-compiler package and removed the Java packages.
@dimakuv We did not face any such issue. The CI setup we have for running gsc workloads is stable. We have tested the helloworld, bash example with distro as "auto", "distro specified" in config.yaml and also tested "gsc build-gramine" feature. No issues seen
gsc.py line 268 at r10 (raw file):
Previously, mkow (Michał Kowalczyk) wrote…
Not done.
Done. Sorry my bad.
gsc.py line 248 at r14 (raw file):
Previously, adarshan-intel (Adarsh Anand) wrote…
Done.
The colon (:) will not be used because in the function template_path, we are splitting the distro based on : in fetch_and_validate_distro_support. Therefore, using colon in the template_path function as you suggested would result in an error as distro becomes exactly quay.io/centos/centos
gsc.py line 248 at r14 (raw file):
Previously, mkow (Michał Kowalczyk) wrote…
Ok, right, but what about the rest of my comment?
Done, made == comparison