graphene icon indicating copy to clipboard operation
graphene copied to clipboard

[LibOS] rename syscall is not working

Open boryspoplawski opened this issue 6 years ago • 4 comments

rename syscall in most cases triggers BUG() PoC: creat("a", ...); rename("a", "b");

boryspoplawski avatar Aug 07 '19 12:08 boryspoplawski

#909 and #910 summarize my findings. Thanks for digging into this!

thomasknauth avatar Aug 08 '19 23:08 thomasknauth

We merged #1000 currently. I guess this issue should remain open since not all code paths of rename syscalls are fixed. @boryspoplawski, if you feel that this issue can be closed, feel free to do it.

dimakuv avatar Sep 19 '19 00:09 dimakuv

I think this should stay open at least as long as rename does not work correctly on all combinations of arguments involving only regular files and directories.

boryspoplawski avatar Sep 24 '19 19:09 boryspoplawski

The rename syscall was mostly fixed by Borys in https://github.com/oscarlab/graphene/pull/943. But there are still cases that are broken. So keeping this issue open and adding rather-high priority.

dimakuv avatar Jul 14 '21 14:07 dimakuv