gramine icon indicating copy to clipboard operation
gramine copied to clipboard

[tests] Fix tampering tests for protected files

Open g2flyer opened this issue 1 year ago • 1 comments

Description of the changes

Test test_500_invalid always failed as test files to decrypt always had an illegal filename masking the actual intended tampering. Fixing this in libos/test/fs/test_enc.py showed that a number of intended tampering use-cases in fact were uncatchable. This PR fixes the file path in the test driver test_nec.py, removes ineffective tampering use-cases and adds some tampering with ciphertext on headers.

The PR also (in a separate commit) improves debuggability of python tests by optionally allow to skip the teardown of the test artifacts and run all tests for 500 instead of aborting on first failure.

How to test this PR?

Run usual regression tests


This change is Reviewable

g2flyer avatar Aug 23 '24 19:08 g2flyer

Jenkins, test this please

dimakuv avatar Sep 04 '24 06:09 dimakuv

Jenkins, test this please

kailun-qin avatar Nov 20 '24 04:11 kailun-qin

Jenkins, retest this please

mkow avatar Nov 28 '24 11:11 mkow

@kailun-qin somehow my force-push (with just docu update) in response to Michal's review invalided your approval (but interestingly not Dmitriis). Hence i did re-request another review. Sorry for the hassle ...

g2flyer avatar Dec 03 '24 18:12 g2flyer

Jenkins, retest this please

mkow avatar Dec 12 '24 19:12 mkow

Jenkins, retest this please

mkow avatar Dec 13 '24 15:12 mkow

Jenkins, retest this please

mkow avatar Dec 13 '24 15:12 mkow