gramener
ENH: Added openpyxl engine in read excel as xlrd stopped support for xlsx
Reading xlsx files through openpyxl engine. As xlrd module stopped supporting xlsx files
@naveenreddymanukonda -- two inputs:
- [ ] In case the user specifies the engine explicitly, this can cause an error. For example, if I call
gramex.cache.open('data.xlsx', engine='openpyxl'). You may want to usekwargs.setdefault('engine', 'openpyxl')instead. - [ ] Is there any file openpyxl can open that xlrd cannot? We can add that as a test case at https://github.com/gramener/gramex/blob/master/testlib/test_cache_module.py
@sanand0
openpyxl doesn't support xls format based on the extension of the file will set the default engine. (link)
Please let me know your thoughts.
Let’s use xlrd as the default for XLS files, if it supports it. Is that OK?
On Mon, 21 Dec 2020 at 7:13 AM, naveenreddymanukonda < [email protected]> wrote:
@sanand0 https://github.com/sanand0 openpyxl doesn't support xls format based on the extension of the file will set the default engine. Please let me know your thoughts.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/gramener/gramex/pull/351#issuecomment-748712114, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPR5SIXKI566RT445UBK3SV2R37ANCNFSM4VB47ZDQ .
-- Thanks Anand
@sanand0
excel_format = io.split('.')[-1]
if excel_format == 'xls':
kwargs.setdefault('engine', 'xlrd')
elif excel_format == 'xlsx':
kwargs.setdefault('engine', 'openpyxl')
Can we go with the above code
Yes, @naveenreddymanukonda. You could consider .endswith() as well. Please remember that the extension can be in lowercase or uppercase or both.
I'll make these changes and merge. No further edits required.
Thank you!