Thomas Grainger

Issues when importing requests with import_patched after importing normally

12

Not sure if this is requests fault or eventlets ``` python graingert@MS-7681-ubu:~$ python Python 2.7.3 (default, Sep 26 2012, 21:51:14) [GCC 4.7.2] on linux2 Type "help", "copyright", "credits" or "license"...

use a canary task to detect `asyncio.run` shutdown - and join selector thread there

1

I was looking at trying to shutdown the selector thread when using `asyncio.run`, and I think it's possible by starting a task that sleeps until it is cancelled, and then...

Try to skip getaddrinfo if "host" is already an IP

9

TCPClient always calls `resolver.resolve(` even if `"host"` is already an IP https://github.com/tornadoweb/tornado/blob/00c9e0ae31a5a0d12e09109fb77ffe391bfe1131/tornado/tcpclient.py#L260-L265 asyncio has a nice implementation that skips the getaddrinfo call https://github.com/python/cpython/blob/b5527688aae11d0b5af58176267a9943576e71e5/Lib/asyncio/base_events.py#L1369-L1380 in this case

Fixes #3113

make lxml dep optional

1

the lxml dependency is a very big dep an it's only used for validating root level elments and the overall expression.

Incorrect docstring handling

6

The syntax highlighting for https://github.com/farcepest/MySQLdb1/blob/9b0b59f1bbe0029757b9b15d1c71586eaca1109c/MySQLdb/cursors.py Seems to be incorrect, it marks most of the file as a string.