grain icon indicating copy to clipboard operation
grain copied to clipboard

Find way to consistently test size of type metadata

Open ospencer opened this issue 3 years ago • 1 comments

See #1833

We had a test that checked the default amount of type metadata, but as changes are made to the runtime and Pervasives, this number changes, which means the test would constantly need to be updated. We could maybe test a range of acceptable values, or craft an example that shouldn't change with respect to the runtime/Pervasives.

ospencer avatar Apr 26 '23 19:04 ospencer

Another approach is some sort of snapshot where we allow it to grow but only within a range of the old value given a range would still need to be updated if we pushed too far. but I think if it grows in one pr more then a couple of bytes we might have a problem.

on the note of the range of acceptable values we don't want our default memory usage going out of control so we might be fine just picking a higher bound and if are coming up on that maybe investigation needs to be done into why we are using so much in the first place.

spotandjake avatar Apr 26 '23 19:04 spotandjake