grails-spring-security-ui icon indicating copy to clipboard operation
grails-spring-security-ui copied to clipboard

Published 20 hours ago • verified publisher icon grails

Grails 7: grails-spring-security-ui

Open bkoehm opened this issue 1 year ago • 1 comments

bkoehm avatar Oct 02 '24 21:10 bkoehm

Tests are not passing. Needs help from others (possibly from @codeconsole).

bkoehm avatar Oct 02 '24 22:10 bkoehm

I have started looking at the UserSpec test errors. It appears to be related to GSP/Sitemesh, as the page title does not seem to render correctly on /user/search.

matrei avatar Dec 17 '24 22:12 matrei

I have started looking at the UserSpec test errors. It appears to be related to GSP/Sitemesh, as the page title does not seem to render correctly on /user/search.

@matrei My apologies, it looks like we both were working on this at the exact same time. I just saw your comment, just as I pushed a new commit that addresses this: https://github.com/bkoehm/grails-spring-security-ui/commit/8a3df415c61ea93034daf79f11b15b76610aafaf

If you feel that this isn't the right solution, it's no problem, I can drop the commit and force-push.

P.S. There are still test failures, but this addresses the missing page title.

bkoehm avatar Dec 17 '24 23:12 bkoehm

My apologies, it looks like we both were working on this at the exact same time. I just saw your comment, just as I pushed a new commit that addresses this: bkoehm@8a3df41

@bkoehm That's great! I just made this note and went to bed anyways.

So, is this a breaking change in Sitemesh 3, or why did it work before Grails 7? I does not seem to be documented in the upgrade gotchas?

matrei avatar Dec 18 '24 06:12 matrei

@matrei @bkoehm

There was still a browser.url assignment in AbstractSecuritySpec - this url would be the local machine and not the container. I've gone ahead and pushed a fix for that.

jdaugherty avatar Dec 18 '24 12:12 jdaugherty

My apologies, it looks like we both were working on this at the exact same time. I just saw your comment, just as I pushed a new commit that addresses this: bkoehm@8a3df41

@bkoehm That's great! I just made this note and went to bed anyways.

So, is this a breaking change in Sitemesh 3, or why did it work before Grails 7? I does not seem to be documented in the upgrade gotchas?

@matrei I don't know if Sitemesh 3 has a breaking change related to page titles and I also don't know if this plugin is working for Grails 6.

bkoehm avatar Dec 18 '24 15:12 bkoehm