Removed marked for removal

Open codeconsole opened this issue 1 year ago • 2 comments

@matrei any idea what is going on here?

Oct 16 '24 22:10 codeconsole

@codeconsole Looking at the comment in the code, It looks like there was a problem with the src/main/resources/META-INF/grails.factories file being overridden by a version generated by the compileGroovy task.

So, apparently a grails.factories file is generated by the compileGroovy task and this workaround directly deletes it so it does not override the one in src.

Looking a the "Remove after 5.0.0.M2" TODO, it seems that this commit is meant to fix this, but the workaround here was never removed.

Maybe the fix, didn't work, or it was just forgotten to remove the workaround. I'll try out the code later to see what it does.

Nov 05 '24 23:11 matrei

When I tested this, removing this causes it to still fail. I had to leave these in the gradle files.

Jan 16 '25 20:01 jdaugherty