grails-data-mapping icon indicating copy to clipboard operation
grails-data-mapping copied to clipboard

Bug in GrailsDataBinder.java in branch 8.1.x and others.

Open dertalai opened this issue 7 months ago • 4 comments

3 months ago, I've reported this bug in GrailsDdataBinder in branch 7.2.x: https://github.com/grails/grails-data-hibernate5/commit/8d0e14b202e470369ede5bb7b4203cbee9e06366

Now, using Grails 6.2.3 I see same problem in 8.1.x branch, but since https://github.com/grails/grails-data-hibernate5 is archived, I came here. But I cannot find the file in this repo. Can someone help me?

BTW, the bug may be in some other branches. Someone corrected it in 9.0.x though.

dertalai avatar May 14 '25 09:05 dertalai

Here it is: https://github.com/apache/grails-core/blob/7.0.x/grails-data-hibernate5/core/src/main/groovy/org/grails/orm/hibernate/cfg/GrailsDomainBinder.java

matrei avatar May 14 '25 10:05 matrei

Here it is: https://github.com/apache/grails-core/blob/7.0.x/grails-data-hibernate5/core/src/main/groovy/org/grails/orm/hibernate/cfg/GrailsDomainBinder.java

Thanks. I've already read that from Grails 7, that's the place to go. But my problem is related to Grails 6.2.x branch.

Edit:

$ cat .git/config | grep url
	url = https://github.com/apache/grails-core/
$ git branch
  6.2.x
* 7.0.x
$ find . -name GrailsDomainBinder.java
./grails-data-hibernate5/core/src/main/groovy/org/grails/orm/hibernate/cfg/GrailsDomainBinder.java
$ git checkout 6.2.x 
Cambiado a rama '6.2.x'
Tu rama está actualizada con 'origin/6.2.x'.
$ git branch
* 6.2.x
  7.0.x
$ find . -name GrailsDomainBinder.java
$

dertalai avatar May 14 '25 10:05 dertalai

Oh, I see, that is a problem. @jdaugherty How can we release patches to https://github.com/grails/grails-data-hibernate5/tree/8.1.x?

matrei avatar May 14 '25 20:05 matrei

the branches are disjoint, so you'd have to checkout the last commit and create a branch from it. Or we could create a build out of the original repo and manually merge into data mapping.

jdaugherty avatar May 14 '25 20:05 jdaugherty