grails-core icon indicating copy to clipboard operation
grails-core copied to clipboard
verified publisher icon grails

Test-Case for #14753

Open robertoschwald opened this issue 7 months ago • 5 comments

Test-Case for #14753

robertoschwald avatar May 19 '25 08:05 robertoschwald

Is this test supposed to fail before #14753 is merged?

matrei avatar May 19 '25 09:05 matrei

This PRs base branch is apache:issue-11795, the base for PR #14753 @jdaugherty rebased my original PR into a new one I cannot push to.

robertoschwald avatar May 19 '25 09:05 robertoschwald

OK, but when I run the test added in this PR, with branch 7.0.x checked out, it succeeds. I would expect it to fail before #14753 is merged. It makes me wonder if the test validates what it's suppose to validate. It's likely I'm missing something so I just want to hear if this is expected behavior.

matrei avatar May 19 '25 10:05 matrei

The problem with bundle ordering materalized here when adding a PluginAwareResourceBundleMessageSource messageSource definition and sets own basenames to be able to overwrite other bundles keys in a centralized bundle file. Then the plugin basenames were first in the list, not last. So yes, the test should work against 7.0.0, but also with #14753

robertoschwald avatar May 19 '25 13:05 robertoschwald

Can we add a test for the problem that this fixes? to show it fails in 7 prior to the fix?

jdaugherty avatar May 19 '25 15:05 jdaugherty

@jamesfredley I don't think this should have been merged. We needed a test case that showed this was broken prior to the fixes

jdaugherty avatar Aug 18 '25 22:08 jdaugherty

@jdaugherty Agreed. I merged to two newest PRs together as a starting point, since it was disjointed and hard to follow across the set of PRs.

jamesfredley avatar Aug 18 '25 22:08 jamesfredley