grails-core icon indicating copy to clipboard operation
grails-core copied to clipboard

Issue #11318 apply Generated annotation to generated Controller Action

Open aulea opened this issue 2 years ago • 5 comments

apply Generated annotation to ControllerActionTransformer generated methods, to improve test coverage reports

aulea avatar Mar 25 '22 12:03 aulea

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 25 '22 12:03 CLAassistant

@aulea remember to sign the CLA so we can get this nice fix applied

andersaaberg avatar Apr 27 '22 09:04 andersaaberg

I have now, but the badge is not updated. At least, when i follow the assignment link, then it says that i have agreed with it.

aulea avatar Apr 27 '22 10:04 aulea

@aulea : sorry for the late reply. It sounds very strange that the CLA does not update after your signature. I've tried it before, where I accidentally made the commit using my work email instead of my private email that I use for my Github account. Try to verify that the emailaddress in the commit matches your GitHub account - you can see the commit email address here: https://github.com/grails/grails-core/pull/12446/commits/9090187197d96cc0939feb69810e65b128015a01.patch

andersaaberg avatar Jun 04 '22 20:06 andersaaberg

you were right, it was committed with different email address

aulea avatar Jun 08 '22 13:06 aulea

Thank you for the pull request. I am currently working on merging these changes manually. Also, I think we should use Groovy org.apache.groovy.ast.tools.ClassUtils.addGeneratedMethod(ClassNode cNode, MethodNode mNode) instead of explicitly calling AnnotatedNodeUtils.markAsGenerated(classNode, method);.

puneetbehl avatar Oct 28 '22 07:10 puneetbehl

Merged with 5b1e1c485e31c5a4bba127f4f1c157b4f95c5597

puneetbehl avatar Nov 02 '22 12:11 puneetbehl