erase-install icon indicating copy to clipboard operation
erase-install copied to clipboard

[BUG] SwiftDialog displaying blank squares - SF Symbols in use not compatible with some versions of macOS

Open BigMacAdmin opened this issue 2 years ago • 2 comments

Describe the bug The wiki states that eraseinstall.sh v.28+ should be compatible with macOS v.11 and up, however some SF symbols in use with SwiftDialog windows are not available in macOS 11 and 12

Using the SFSymbols.app provided by Apple, they tell us which version of macOS different symbols were introduced. When run on earlier versions of macOS, these icons appear as blank squares.

To Reproduce

  • externaldrive.fill.badge.exclamationmark requires macOS 13.0+ (Script line 342)
  • person.badge.key.fill requires macOS 12.3+ (Script line 110)
  • laptopcomputer.trianglebadge.exclamationmark requires macOS 12+ (Script line 207)
  • powerplug.fill requires macOS 12+ (Script line 594)

Expected behavior SwiftDialog handles this problem on your behalf by showing a blank square, but I've seen folks on Slack ask about this.

Code/log output There is no relevant code snippet for htis

Screenshots image

Environment (please complete the following information):

  • Relevant for all devices running macOS 11 or macOS 12

Additional context Possible Solutions:

  1. Replace these icons with icons released in macOS 11
  2. Add logic to set these icons dependent upon the source OS
  3. Close this issue as "won't fix/don't care"

Let me know if you'd like a pull request for option 1 or 2

BigMacAdmin avatar Nov 29 '23 18:11 BigMacAdmin

I'm going with these replacements, all of which should be compatible with macOS 11:

  • Replace externaldrive.fill.badge.exclamationmark with externaldrive.fill.badge.xmark
Screenshot 2023-12-08 at 15 12 33
  • Replace person.badge.key.fill with key.fill
Screenshot 2023-12-08 at 15 15 32
  • Replace laptopcomputer.trianglebadge.exclamationmark with the FindMyMac icon
Screenshot 2023-12-08 at 15 14 18
  • Replace power.fill with bolt.slash.fill
Screenshot 2023-12-08 at 15 16 32

Look good?

grahampugh avatar Dec 08 '23 14:12 grahampugh

https://github.com/grahampugh/erase-install/releases/tag/v32.0 to test

grahampugh avatar Dec 08 '23 15:12 grahampugh