Got error on NavigationStackView.onAfterUpdateTransaction

[mazipan]

I am not sure how to reproduce this issue, but this is an error from our Crashlytics dashboard.

[grahammendick]

Hey, thanks for getting in touch. Don't worry that you can't reproduce it. An error like that is usually an edge case that relies on a very specific sequence and timing. I think the fix is to check the fragment isAdded before the fragments are updated in the NavigationStackView

if (scenes.size() == 0 || !fragment.isAdded() || fragment.getChildFragmentManager().isStateSaved())
    return;

Is this something you can test out and see if the error goes away?

[mazipan]

We can reconfirm by check out Crashlytics dashboard, but I am afraid that our current release cycle can not let us check the feedback in short time.

But we can patch the library by our own for instance, using your code above. Then after we sure that the error gone (which may takes time), we will send you a PR to fix the issue.

How about that?

[grahammendick]

Thanks @mazipan that sounds great 👍

[grahammendick]

Hey @mazipan, how's it going? I'm just checking in to see if you've any feedback yet

[mazipan]

We've patching the library since 5 August.

@galihlprakoso could you help to confirming that the error is gone on our Crashlytics?

[grahammendick]

@mazipan could you check, please?

[grahammendick]

@mazipan it's cool if it's going to take a while to go through the logs. Just let me know, please 🙏

[grahammendick]

@mazipan I'll leave this open for another 2 weeks. If I haven't heard from you before then I'll close it :(

[galihlprakoso]

Really really sorry for the late late late response.. 🙏🏻 🥲 I confirmed that the issue is not happening anymore after the patch. Thanks a lot! @grahammendick

[grahammendick]

Ah, no problem. Thank you for letting me know. The fix will be in the next release