grahamearley
Suport for Multiple Databases in one GCP project
Simple change enabling access to multiple databases. It is fully backward compatible.
I was gonna implement your code in my repo and noticed two things.
x-goog-request-params header is added, I am not quite sure why this was added. I tried the base code without the header and it didn't throw any errors.
Although I see you modified tests, some tests fail since the doc.path getter will not match since it relies on regex so you need to modify it there.
It is to conform with a Google spec - not my invention :-)
On Fri, Feb 28, 2025 at 3:41 PM abkarino @.***> wrote:
I was gonna implement your code in my repo and noticed two things. x-goog-request-params header is added, I am not quite sure why this was added. I tried the base code without the header and it didn't throw any errors. Although I see you modified tests, some tests fail since the doc.path getter will not match since it relies on regex so you need to modify it there.
— Reply to this email directly, view it on GitHub https://github.com/grahamearley/FirestoreGoogleAppsScript/pull/167#issuecomment-2690812417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJBDYAQT3O2TPTKYZUDSD2SBYS3AVCNFSM6AAAAABYCPBDWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJQHAYTENBRG4 . You are receiving this because you authored the thread.Message ID: @.***> [image: abkarino]abkarino left a comment (grahamearley/FirestoreGoogleAppsScript#167) https://github.com/grahamearley/FirestoreGoogleAppsScript/pull/167#issuecomment-2690812417
I was gonna implement your code in my repo and noticed two things. x-goog-request-params header is added, I am not quite sure why this was added. I tried the base code without the header and it didn't throw any errors. Although I see you modified tests, some tests fail since the doc.path getter will not match since it relies on regex so you need to modify it there.
— Reply to this email directly, view it on GitHub https://github.com/grahamearley/FirestoreGoogleAppsScript/pull/167#issuecomment-2690812417, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJBDYAQT3O2TPTKYZUDSD2SBYS3AVCNFSM6AAAAABYCPBDWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJQHAYTENBRG4 . You are receiving this because you authored the thread.Message ID: @.***>