m3u8 icon indicating copy to clipboard operation
m3u8 copied to clipboard

EXT-X-KEY tags apply to all segments that come after it

Open tmm1 opened this issue 5 years ago • 6 comments

This fixes an issue where MediaSegment.Key is not set correctly

tmm1 avatar Jul 07 '19 15:07 tmm1

Coverage Status

Coverage decreased (-0.02%) to 74.127% when pulling cb4f5a669a5642b3f769a4efb2a19ff52bb81945 on fancybits:segment-keys into 920643e7fcabbe6078c26b65e6b38ae9306f5b33 on grafov:master.

coveralls avatar Jul 07 '19 15:07 coveralls

Coverage Status

Coverage decreased (-0.02%) to 74.127% when pulling cb4f5a669a5642b3f769a4efb2a19ff52bb81945 on fancybits:segment-keys into 920643e7fcabbe6078c26b65e6b38ae9306f5b33 on grafov:master.

coveralls avatar Jul 07 '19 15:07 coveralls

Coverage Status

Coverage decreased (-0.02%) to 74.127% when pulling cb4f5a669a5642b3f769a4efb2a19ff52bb81945 on fancybits:segment-keys into 920643e7fcabbe6078c26b65e6b38ae9306f5b33 on grafov:master.

coveralls avatar Jul 07 '19 15:07 coveralls

Ping @leikao

tmm1 avatar Jul 16 '19 04:07 tmm1

This change would cause decoding and re-encoding some playlists to have KEY tags on every segment when they previously did not. For a long playlist this could add a lot of unnecessary bytes to the m3u8.

mjneil avatar Jul 16 '19 16:07 mjneil

@tmm1 actually interpreting the key tags (application to a segment) is the job of the code using this library (e.g. a streaming player). The playlist representation should be as small as possible, so also what @mjneil writes.

unki2aut avatar Apr 14 '21 11:04 unki2aut