xk6-websockets icon indicating copy to clipboard operation
xk6-websockets copied to clipboard

Consider not using gorilla

Open mstoykov opened this issue 1 year ago • 2 comments

https://github.com/gorilla/websocket isn't exactly known for it's awesome performance an has for years been undermaintained in my (albeit small) experience with it.

Quick goolge search finds us https://github.com/nhooyr/websocket - which is minimal and idiomatic (author words), but unfortunately hasn't had update since april 2021 :( and likely isn't as performant as: https://github.com/gobwas/ws - supposedly really efficient, again no release from 2021 this time from July :(

Just because they haven't been updated in a while might not be that big of a problem if they work correctly - I don't think the websockets specification has changed in years.

The more important question likely is which one gives us better performance and does it make sense to move away from gorilla which has served as well so far.

Also possible think to weight in is #3 which might change depending on the implementation we use :shrug:

mstoykov avatar Jul 21 '22 07:07 mstoykov