User-configurable overrides refuses span-metrics-size as valid processor
Describe the bug
When trying to update metrics_generator.processors through the user-configurable overrides, when the array contains the processor span-metrics-size, the request is rejected with metrics_generator.processor "span-metrics-size" is not a known processor, valid values: [service-graphs span-metrics local-blocks].
To Reproduce Steps to reproduce the behavior:
- Start Tempo (SHA or version)
- Update
metrics_generator.processorsthrough the user-configurable overrides
Expected behavior
span-metrics-size is a valid subprocessor of the span-metrics processor and should be accepted.
Environment: N/A
Additional Context
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.
@kvrhdn I've started working on this and I'd like to confirm if I should add support for the other spanmetrics sub processors (span-metrics-latency, span-metrics-count) in addition to span-metrics-size
Yes that's right. We should also allow all of the subprocessors defined here: https://github.com/grafana/tempo/blob/main/modules/generator/processor/spanmetrics/subprocessors.go