tempo icon indicating copy to clipboard operation
tempo copied to clipboard

Module path needs to be updated with '/v2'

Open beauji1116jbn opened this issue 1 year ago • 2 comments

Currently this repo doesn't work correctly with "go get" because the module name is not compatible with the current major version. Please help to update the module path, like you did in the Loki project: https://github.com/grafana/loki/blob/main/go.mod#L1

beauji1116jbn avatar Jun 27 '24 13:06 beauji1116jbn

Sure, I'd accept this PR as long as it doesn't impact our build and testing processes.

joe-elliott avatar Jun 27 '24 13:06 joe-elliott

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.

github-actions[bot] avatar Aug 27 '24 00:08 github-actions[bot]

I just ran into this, too. The only version I can use with go get is 1.5.0 - which is very old. The reason I'm importing tempo is to use the generated protobuf files to deserialize a Tempo API response.

stephanos avatar Dec 21 '24 23:12 stephanos

You are not limited to importing just 1.5.0. You can import any commit you want using:

go get github.com/grafana/tempo@<commit hash>

joe-elliott avatar Jan 02 '25 13:01 joe-elliott

Oh, my apologies! I didn't realize that would just work like that. Can confirm, that's a reasonable workaround 👍

stephanos avatar Jan 02 '25 18:01 stephanos