tempo
tempo copied to clipboard
Add vparquet4 encoding
What this PR does: This adds a new encoding vParquet4 to Tempo (the default encoding remains unchanged). The new encoding improves support for links, events, and attributes with array values. This is a prerequisite better support of links, events, and arrays in TraceQL as proposed by the TraceQL Extensions design proposal.
The vParquet4 encoding is considered experimental for now.
There are still some things missing from this PR, those will be subject to separate PRs:
- A CLI to analyze blocks in order to find good candidates for dedicated attributes
- Documentation about how to enable vParquet4
Hints for reviewers: This PR was created from the commits to the vparquet3
directory in the branch main-vparquet4
(diff). Since this PR adds a whole new directory vparquet4
, it can be helpful to review the individual PRs in order to see the differences between vParquet3 and vParquet4.
Which issue(s) this PR fixes: Fixes grafana/tempo-squad#384
Checklist
- [ ] Tests updated
- [ ] Documentation added
- [ ]
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
Ingester and querier memory usage is up
@andreasgerstmayr thanks for submitting the PRs
@stoewer @andreasgerstmayr this is very close. thank you for your work. there are 3 threads left to resolve. two of which are covered by andreas's PR: https://github.com/stoewer/tempo/pull/5
if we push on this i think we can get it quite soon. let me know when you're ready for a final review 🙏