tempo icon indicating copy to clipboard operation
tempo copied to clipboard

[Search] if service name is selected only show relevant span names

Open ToonTijtgat2 opened this issue 1 year ago • 5 comments

Describe the bug While exploring the tracing via the tempo datasource in grafana the drop down possibilities are not relevant. If I select a Resource Service name first and then try to select a Span name from the dropdown it shows the possibilities of all resource names instead of only from the selected one.

This is causing to have empty searches and confusion. if the span name does not exist for the Resource Service name it gives no results.

To Reproduce Steps to reproduce the behavior:

  1. Open the tempo datasource in grafana
  2. Select a Resource Service Name
  3. Open the Select value dropdown of Span name and you'll find all possible span names instead of the once related to the selected Resource Service Name

Expected behavior I expect that if I select a Resource Service name that the next dropdown's would be relevant to this service name. Like it's also for loki/mimir when you have a label selected, and you try to filter down on an extra label, it only show the labels relevant for the previous selection.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: helm
  • Version: 2.3.1

ToonTijtgat2 avatar Feb 02 '24 10:02 ToonTijtgat2

This issue is a duplicate of https://github.com/grafana/grafana/issues/81776 since I'm not sure if it's for the grafana team or tempo team.

ToonTijtgat2 avatar Feb 02 '24 10:02 ToonTijtgat2

This has been fixed in Tempo here: https://github.com/grafana/tempo/pull/2433/files

It's currently behind a feature flag, but that was defaulted to true here: https://github.com/grafana/tempo/pull/3178

The next version of Tempo and latest Grafana will filter span names (and all other tags) as desired.

joe-elliott avatar Feb 02 '24 14:02 joe-elliott

which do you expect new tempo version release?

pingping95 avatar Feb 03 '24 01:02 pingping95

Likely later this month/early next month.

joe-elliott avatar Feb 05 '24 17:02 joe-elliott

Thanks a lot for fixing it :)

nirmaljeet-singh-groww avatar Feb 06 '24 12:02 nirmaljeet-singh-groww

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity. Please apply keepalive label to exempt this Issue.

github-actions[bot] avatar Apr 07 '24 00:04 github-actions[bot]

closed with https://github.com/grafana/tempo/pull/3178 and released in 2.4.0

ToonTijtgat2 avatar Apr 08 '24 06:04 ToonTijtgat2