tempo
tempo copied to clipboard
Use snake case on Azure Storage config
What this PR does: Use snake case on Azure Storage config
Which issue(s) this PR fixes: Fixes #1879
Checklist
- [x] Tests updated
- [x] Documentation added
- [x]
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
Should I update the docker-compose azure example now or after Tempo 2.0 is released?
Thank you for this fix. I've been wanting to do it for awhile, but haven't found the time.
There is also a file we use for a local azure example that will need to be updated:
/example/docker-compose/azure/tempo-azure.yaml
It also looks like you need to run
make jsonnet
to rebuild the jsonnet files? This requires some local tooling setup that can be kind of annoying if you never use jsonnet. I can run this and push to your branch if it's easier.Thanks @faustodavid!
Happy to contribute! :D
@joe-elliott I wasn't sure if I should update the docker-compose example because if somebody tries to run it without compiling Tempo it will fail.
@joe-elliott I wasn't sure if I should update the docker-compose example because if somebody tries to run it without compiling Tempo it will fail.
This is a good point, but I think we have to keep the examples consistent with tip of main. I'd prefer it fail if you have an older tempo:latest
than if you have the most recent tempo:latest