tempo icon indicating copy to clipboard operation
tempo copied to clipboard

Fix broken link to blog post

Open cincodenada opened this issue 3 years ago • 2 comments

This URL changed at some point after August 15, 2021. I'd also ask you to pass a note to whoever runs the blog: please don't change URLs like this, especially without a redirect, it's really poor practice.

The headline appears to have been changed for branding reasons ("Grafana Agent" -> "Grafana Cloud Agent"), which is fine, but that headline change should not be propagated back to the URL as well. Most blogging platforms allow you to do this (and should do so by default), and news sites and such properly change headlines while preserving the URL all the time.

In the meantime, this fixes the one reference I happened to stumble across, out of the probably-many references to the old URL across the web. The actual fix is to set up a redirect from the old URL to the new URL, but I can't submit a PR for that, so please forward that request along as well!

Also, while I'm at it, I ran across a blogpost on grafanalabs, which is another place with a now-broken link, and noticed that the certificate I got is invalid - it doesn't include grafanalabs.com in its alt names, and thus is not a valid certificate for that domain. So, probably pass that onto your web folks as well.

What this PR does: Fixes a broken link to a blogpost in the documentation Which issue(s) this PR fixes: N/A

Checklist

  • [ N/A ] Tests updated
  • [x] Documentation added
  • [?] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

cincodenada avatar Jan 13 '22 21:01 cincodenada

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 13 '22 21:01 CLAassistant

Hi @cincodenada. Thanks for reporting this.

I had a chat with the agent team and they mentioned that we renamed from Grafana Cloud Agent -> Grafana Agent, so not sure why that URL changed in that direction 🤔

In any case, I think the way forward is for us to change the URL back to https://grafana.com/blog/2020/11/17/tracing-with-the-grafana-agent-and-grafana-tempo/. I will pass this on and will close this PR when its changed.

(Converting to draft to avoid merging)

annanay25 avatar Jan 17 '22 08:01 annanay25

This PR has been automatically marked as stale because it has not had any activity in the past 60 days. The next time this stale check runs, the stale label will be removed if there is new activity. This pull request will be closed in 15 days if there is no new activity. Please apply keepalive label to exempt this Pull Request.

github-actions[bot] avatar Nov 17 '22 00:11 github-actions[bot]