tanka icon indicating copy to clipboard operation
tanka copied to clipboard

feat: Add support for overriding environment label (#824)

Open DeanBruntThirdfort opened this issue 2 years ago • 3 comments

This change looks to add support for the environment label override from fields that #824 requested. This allows users to alter the label themselves which allows a workaround of the issue described in #824.

As this is my first time contributing, I've not fully tidied this PR up yet as I want to get feedback from the maintainers on whether approach is sound/in-line with the vision of the codebase and if there's anything else I should bear in mind.

DeanBruntThirdfort avatar Dec 15 '23 17:12 DeanBruntThirdfort

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 15 '23 17:12 CLAassistant

Is there anything I can do to aid with the progression of this being reviewed?

DeanBruntThirdfort avatar Feb 13 '24 11:02 DeanBruntThirdfort

Bump. I'm waiting on this to use Tanka in any capacity since this is a giant footgun that will destroy deployments and eat data.

Maintainers, any thoughts?

remram44 avatar Apr 18 '24 23:04 remram44