feat: add probe duration and SSL expiry alerts

[mem]

Signed-off-by: Marcelo E. Magallon [email protected]

[rdubrock]

So I dove in and did a take on how I'd solve this problem: https://github.com/grafana/synthetic-monitoring-app/pull/426

The main thing is that I feel like the different forms are similar enough that we can just abstract the differences and pass those as props. What changes is some of the language in the UI and threshold values on a couple inputs, and the form itself doesn't really have to know about those things.

I also think the approach going on here works fine! It just needs a few small tweaks to pass the tests I believe. I'll leave it up to you to compare and see which one appeals more.

[mem]

So I dove in and did a take on how I'd solve this problem: #426

The main thing is that I feel like the different forms are similar enough that we can just abstract the differences and pass those as props. What changes is some of the language in the UI and threshold values on a couple inputs, and the form itself doesn't really have to know about those things.

I also think the approach going on here works fine! It just needs a few small tweaks to pass the tests I believe. I'll leave it up to you to compare and see which one appeals more.

Thanks, what you are doing makes sense to me!

The only reason I didn't start by doing that is because I wasn't sure how different the different alerts would be, but you are right, they are still very similar, and the differences are better captured in the way you are doing it.

[CLAassistant]

All committers have signed the CLA.

[rdubrock]

Closing because it will be covered by our future plans for handling alerting