pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

Consider using Annotations for storing github integration references instead of Mapping json

Open korniltsev opened this issue 4 months ago • 4 comments

https://github.com/grafana/pyroscope/pull/3956#discussion_r1975245891

korniltsev avatar Aug 25 '25 08:08 korniltsev

Ideally I would like to have labels/attributes that are attached to mappings. (This is captured here: https://github.com/grafana/pyroscope/issues/4262)

This would allow us to store any information relating to mappings in the correct place. This is very aligned to what OTLP will have: https://github.com/open-telemetry/opentelemetry-proto/blob/c0a98a1847d3124ac5f9ecd02d0e2d2732bbb590/opentelemetry/proto/profiles/v1development/profiles.proto#L439-L440

simonswine avatar Sep 04 '25 14:09 simonswine

@korniltsev May I work on this ?

pkalsi97 avatar Nov 03 '25 10:11 pkalsi97

I agree with Christian its better to wait until otel style mapping attributes are supported

korniltsev-grafanista avatar Nov 03 '25 12:11 korniltsev-grafanista

@korniltsev-grafanista okay !

pkalsi97 avatar Nov 03 '25 13:11 pkalsi97