pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

Create a stub mapping for truncated nodes

Open kolesnikovae opened this issue 1 year ago • 2 comments

When a pprof profile is truncated, we replace the removed nodes with a shared "stub" location (named "other") that references the default mapping (ID == 1), which may lead to ambiguity. Instead, a shared "stub" mapping should be created (probably, even if the profile already has a "stub" mapping created at ingestion).

kolesnikovae avatar Apr 11 '24 04:04 kolesnikovae

Yes I do agree, esp. once we want to attach more information (OTEL spec) to the mapping we should be careful what belongs together or not.

simonswine avatar Apr 11 '24 12:04 simonswine