pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

ServiceMonitor support for monitoring pyroscope in helm

Open rlex opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe.

It will be nice to see serviceMonitor support in helm chart.

Describe the solution you'd like

helm value serviceMonitor.enabled for enabling serviceMonitor from templates

Additional context

Tried to do that myself, but since pyroscope creates both complete and headless service for each component (in distributed mode), i get double metrics. Both services have similar set of labels, so kinda hard to figure out how to filter them out. I saw

prometheus.io/service-monitor=false

label in some charts, is that official prometheus-operator label? Might do the trick.

rlex avatar Dec 05 '23 21:12 rlex

started some work here: https://github.com/grafana/pyroscope/pull/2806

rlex avatar Dec 05 '23 22:12 rlex