pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

RE: Requesting a setting to disable the ability to export to flamegraph.com

Open be-hase opened this issue 2 years ago • 2 comments

The request that was addressed in the following issue seems to have disappeared in pyroscope 1.1 https://github.com/grafana/pyroscope/issues/1186

be-hase avatar Nov 13 '23 05:11 be-hase

+1 to get back this feature.

Adding that the workaround in this comment https://github.com/grafana/pyroscope/issues/1186#issuecomment-1169451605 doesn't seem to work anymore. The POST request to flamegraph.com is done directly in the user's browser, and does not go through pyroscope server.

I am currently preventing the export by setting the DNS of flamegraph.com to localhost as a workaround

# K8s Pod setting
...

hostAliases:
- ip: "127.0.0.1"
   hostnames:
     - "flamegraph.com"

julienvey avatar Dec 22 '23 08:12 julienvey

Looks like the code to enable/disable it is till there but I don't see a way to configure it at runtime

https://github.com/grafana/pyroscope/blob/main/public/app/util/features.ts#L39

julienvey avatar Dec 22 '23 10:12 julienvey