pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

chore(webapp): cleanup features

Open eh-am opened this issue 2 years ago • 2 comments

  • move isAuthRequired to under features
  • parse window.features using zod (this has the potential of breaking the app in cases like passing a number where a boolean it's expected)
  • closes https://github.com/pyroscope-io/pyroscope/issues/1228

eh-am avatar Aug 05 '22 18:08 eh-am

Codecov Report

Merging #1355 (2d2f137) into main (8977fc7) will increase coverage by 0.10%. The diff coverage is 93.34%.

@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
+ Coverage   68.37%   68.46%   +0.10%     
==========================================
  Files         129      129              
  Lines        4252     4242      -10     
  Branches     1155     1135      -20     
==========================================
- Hits         2907     2904       -3     
+ Misses       1340     1333       -7     
  Partials        5        5              
Impacted Files Coverage Δ
webapp/javascript/components/Sidebar.tsx 86.91% <50.00%> (ø)
webapp/javascript/util/features.ts 94.45% <100.00%> (+23.02%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 18:08 codecov[bot]

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 416.69 KB (+0.04% 🔺) 8.4 s (+0.04% 🔺) 2.7 s (-4.39% 🔽) 11 s
webapp/public/assets/app.css 15.23 KB (0%) 305 ms (0%) 0 ms (+100% 🔺) 305 ms
webapp/public/assets/styles.css 9.46 KB (0%) 190 ms (0%) 0 ms (+100% 🔺) 190 ms
packages/pyroscope-flamegraph/dist/index.js 90.77 KB (0%) 1.9 s (0%) 1.6 s (+15% 🔺) 3.4 s
packages/pyroscope-flamegraph/dist/index.node.js 90.63 KB (0%) 1.9 s (0%) 771 ms (-4.99% 🔽) 2.6 s
packages/pyroscope-flamegraph/dist/index.css 7.02 KB (0%) 141 ms (0%) 0 ms (+100% 🔺) 141 ms

github-actions[bot] avatar Aug 05 '22 18:08 github-actions[bot]