pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

feat(webapp): update timeline appearance/ flot pugins refactor [WIP]

Open pavelpashkovsky opened this issue 1 year ago • 13 comments

Short summary on this PR We don't edit any code in Flot anymore. But there are cases when new functionality based on some built-in plugins. In case of upgrading time selection functionality I extracted react-flot/flot/jquery.flot.selection.min into a file ./TimelineChartSelection, where I customised existing logic in accordance with task requirements. It's important to note, that there are 2 types of timeline selection: double and single. All customisation was applied only for single type of selection. Double works in old fashion way (using built-in Flot selection, not plugin-built one).

image

image


I also extended in a bit TimelineChartWrapper API. Now you can set colors for selection boundaries and overlay. Adding colors depending on color mode is in progress

image

pavelpashkovsky avatar Jul 29 '22 12:07 pavelpashkovsky

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 411.17 KB (+0.27% 🔺) 8.3 s (+0.27% 🔺) 3.5 s (+9.32% 🔺) 11.8 s
webapp/public/assets/app.css 14.01 KB (0%) 281 ms (0%) 0 ms (+100% 🔺) 281 ms
webapp/public/assets/styles.css 9.82 KB (0%) 197 ms (0%) 0 ms (+100% 🔺) 197 ms
packages/pyroscope-flamegraph/dist/index.js 90.13 KB (0%) 1.9 s (0%) 1.3 s (-6.49% 🔽) 3.1 s
packages/pyroscope-flamegraph/dist/index.node.js 81.46 KB (0%) 1.7 s (0%) 680 ms (+27.98% 🔺) 2.4 s
packages/pyroscope-flamegraph/dist/index.css 5.83 KB (0%) 117 ms (0%) 0 ms (+100% 🔺) 117 ms

github-actions[bot] avatar Jul 29 '22 12:07 github-actions[bot]

Codecov Report

Merging #1323 (227a088) into main (eab8ef9) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   67.55%   67.55%           
=======================================
  Files         123      123           
  Lines        4040     4040           
  Branches      930      930           
=======================================
  Hits         2729     2729           
  Misses       1307     1307           
  Partials        4        4           
Impacted Files Coverage Δ
...javascript/pages/tagExplorer/components/Legend.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 29 '22 12:07 codecov[bot]

/create-server

pavelpashkovsky avatar Jul 29 '22 13:07 pavelpashkovsky

looks like selection boundaries and overlay are too much pale.

pavelpashkovsky avatar Jul 29 '22 13:07 pavelpashkovsky

@Rperry2174, I can be wrong, but I've just remembered that you wanted to remove these captions several months ago? Should I do this?

image

pavelpashkovsky avatar Jul 29 '22 13:07 pavelpashkovsky

@Rperry2174, I can be wrong, but I've just remembered that you wanted to remove these captions several months ago? Should I do this?

Yeah we can remove these now.

Given the current way that the code is structured what would be the steps to be able to control the selection like this? time_selector_mockup_00_3

Rperry2174 avatar Jul 30 '22 18:07 Rperry2174

/create-server

eh-am avatar Aug 02 '22 15:08 eh-am

/create-server

Rperry2174 avatar Aug 05 '22 16:08 Rperry2174

/create-server

pavelpashkovsky avatar Aug 08 '22 13:08 pavelpashkovsky

/create-server

eh-am avatar Aug 08 '22 14:08 eh-am

/create-server

Rperry2174 avatar Aug 08 '22 17:08 Rperry2174

/create-server

eh-am avatar Aug 09 '22 16:08 eh-am

almost there! I definitely like these selectors better.. Can we make this cursor an "open" hand: image

Rperry2174 avatar Aug 09 '22 19:08 Rperry2174

@Rperry2174, I changed resize cursor to open hand, please re/create-server

pavelpashkovsky avatar Aug 10 '22 09:08 pavelpashkovsky

/create-server

Rperry2174 avatar Aug 10 '22 13:08 Rperry2174