pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

Make flameql ignore spaces

Open eh-am opened this issue 2 years ago • 1 comments

The query cart.service.dotnet.cp{d ="dwad"} should work independent of the amoutn of spaces.

We could solve that at different levels, but I believe the easiest one is to do it at the flameql parser level.

image

image

eh-am avatar Jul 13 '22 16:07 eh-am

Yeah, we definitely should make it work with spaces. As a quick fix I'm thinking about using regex for tag matchers instead of parsing, e.g something like this: ^\s*(\w*)\s*(=|=~|!=|!~)\s*"(.*)"\s*$. The problem is that we would lose some details and in case of an error, the message will be almost meaningless.

Alternatively, if we're going to evolve FlameQL further, I'd also consider using yacc and lex.

kolesnikovae avatar Jul 14 '22 10:07 kolesnikovae