pyroscope
pyroscope copied to clipboard
Make flameql ignore spaces
The query cart.service.dotnet.cp{d ="dwad"}
should work independent of the amoutn of spaces.
We could solve that at different levels, but I believe the easiest one is to do it at the flameql parser level.
Yeah, we definitely should make it work with spaces. As a quick fix I'm thinking about using regex for tag matchers instead of parsing, e.g something like this: ^\s*(\w*)\s*(=|=~|!=|!~)\s*"(.*)"\s*$
. The problem is that we would lose some details and in case of an error, the message will be almost meaningless.
Alternatively, if we're going to evolve FlameQL further, I'd also consider using yacc and lex.