pyroscope-go icon indicating copy to clipboard operation
pyroscope-go copied to clipboard

feat(otlp): experimental otlp support

Open petethepig opened this issue 2 years ago • 3 comments

  • very much a draft at this point.
  • requires a copy of https://github.com/open-telemetry/opentelemetry-proto-profile to be adjacent to the directory
  • works with https://github.com/grafana/pyroscope/pull/2177 and https://github.com/petethepig/opentelemetry-collector/pull/1

petethepig avatar Jul 27 '23 00:07 petethepig

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 27 '23 00:07 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 27 '23 00:07 CLAassistant

May be a good idea to make Remote an interface and otlp implementation of that interface and maybe put otlp implementation in to a separate module, so that people who don't need grpc dependencies do not get them accidentally

korniltsev avatar Jul 27 '23 04:07 korniltsev