oncall icon indicating copy to clipboard operation
oncall copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Allow customized SMS message, fix #197

Open ohidurbappy opened this issue 3 years ago • 1 comments

What's changed

  • Allows Customized SMS messages for Oncall with a Fixed prefix - "Grafana OnCall alert:" as suggested by @Matvey-Kuk to avoid system misuse of any kind.
  • The default content of the sms_title is changed to a template that is very similar to the current SMS format.
  • A new grafana_onlink_organization variable is added to the reserved template variable to be used within a message.

ohidurbappy avatar Sep 17 '22 16:09 ohidurbappy

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 17 '22 16:09 CLAassistant

Closing this as stale, @ohidurbappy feel free to reopen 🙂

vstpme avatar Nov 24 '22 10:11 vstpme

@vadimkerr I didn't write this patch, but I don't think the issue is stale.. this is something I'd like as well.. why was it stalled instead of applied?
This makes it so that sms phone notifications don't show enough quick information to allow somebody to make a quick decision. Why not just say "OnCall:" at the front of the message if you want to have some kind of standard prefix? (also @Matvey-Kuk, since you are the other reviewer)

yokhahn avatar Apr 18 '23 15:04 yokhahn

@yokhahn 13 days after this PR was opened, Vadim performed the review, left a few comments and proposed help to drive this PR forward and make it merged. He closed the PR after waiting for some time for a response from the contributor.

We don't merge PR's until team members are happy with their quality, they provide help with reveiws and providing context, but they don't polish PR's for contributors.

@yokhahn if you want to make this PR merged, I would suggest re-opening it and working together with a team in order to merge it, I don't think the current approach will work.

Matvey-Kuk avatar May 04 '23 19:05 Matvey-Kuk

@yokhahn 13 days after this PR was opened, Vadim performed the review, left a few comments and proposed help to drive this PR forward and make it merged. He closed the PR after waiting for some time for a response from the contributor.

We don't merge PR's until team members are happy with their quality, they provide help with reveiws and providing context, but they don't polish PR's for contributors.

@yokhahn if you want to make this PR merged, I would suggest re-opening it and working together with a team in order to merge it, I don't think the current approach will work.

13 days to stale? Why?

yokhahn avatar May 04 '23 19:05 yokhahn