oncall icon indicating copy to clipboard operation
oncall copied to clipboard

Add a `silenced_at` field for alert group API responses

Open mjs opened this issue 1 year ago • 2 comments

What would you like to see!

The alert groups API returns timestamps for every state except silenced. This means that if a user silences an alert there's no way to know via the API when it was silenced. We would like to know this to help synchronising OnCall alerts to our internal alerting system.

Product Area

Alert Flow & Configuration

Anything else to add?

No response

mjs avatar Feb 19 '24 01:02 mjs

The current version of Grafana OnCall, at the time this issue was opened, is v1.3.105. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you :smile:!

github-actions[bot] avatar Feb 19 '24 01:02 github-actions[bot]

hi there! 👋

I'd be open to reviewing a PR for this if you put one together 🙂

It should be as simple as adding the field in the public API serializer here:

https://github.com/grafana/oncall/blob/dev/engine/apps/public_api/serializers/incidents.py

(+ updating the relevant tests and public documentation)

joeyorlando avatar Feb 20 '24 13:02 joeyorlando