oncall icon indicating copy to clipboard operation
oncall copied to clipboard

ack_url_post and ack_url_get don't work

Open iskhakov opened this issue 2 years ago • 6 comments

  • check and fix ack_url_post and ack_url_get parameters
  • add this feature to the documnetation and highlight in the interface

iskhakov avatar Aug 16 '22 11:08 iskhakov

@iskhakov do we want to add them? Shouldn't it be a feature for a webhook?

Matvey-Kuk avatar Aug 16 '22 13:08 Matvey-Kuk

ack_url_post and ack_url_get are optional payload paramethers which used to exist in the product before oficial release. I think we shouldn't bring this feature back because:

  1. Processing payload paramethers without templating is breaking the concept of "render everything using Jinja" we have. Those paramethers were hardcoded which means if the payload source is not able to form the proper link, the user can't adjust it on the OnCall side.
  2. It's making Webhooks feature not as straightforward. We have "Webhooks" page, it may be not easy to understand that some webhooks are generated because of "magic" paramethers in the alert payload.

What I suggest:

Think of some way to let users issue webhooks not only as an escalation step but also according to events which happened with Alert Group such as (New registered, new alert came, acked, resolved, snoosed), improve the page we have now: Screenshot 2022-08-16 at 16 49 30

Matvey-Kuk avatar Aug 16 '22 13:08 Matvey-Kuk

Nice idea, I'm agree, we need to give the users ability to trigger outgoing webhooks based on the different events, such as incident acknowledged, incident resolved, also we can allow using outgoing webhooks in the personal notifications.

iskhakov avatar Aug 16 '22 13:08 iskhakov

Personal notifications is a great idea! It will increase OnCall's applicability a lot.

Matvey-Kuk avatar Aug 16 '22 13:08 Matvey-Kuk

we also need to

  • add get method to the outgoing webhooks
  • allow using json as a field (right now ninja converts it into string)

iskhakov avatar Aug 16 '22 14:08 iskhakov

This feature would be great. Would be good to be able to specify which alerts can trigger the webhook (e.g. alerts that have a specific label can trigger a webhook).

tommysitehost avatar Sep 12 '22 03:09 tommysitehost

This functionality will be available in Outgoing Webhooks soon https://github.com/grafana/oncall/pull/1844

iskhakov avatar Jun 13 '23 07:06 iskhakov