oncall icon indicating copy to clipboard operation
oncall copied to clipboard

Published 20 hours ago • verified publisher icon grafana

UI bug related to time inputs for "current UTC time is in" range escalation policy step

Open joeyorlando opened this issue 1 year ago • 3 comments

What went wrong?

What happened: https://www.loom.com/share/15cb3e79af1f4c3cb2c5163d9440e074

What did you expect to happen:

  • when I type a valid value into the time range it should not show a red border
  • when I backspace the entire value I should not get a full page error

How do we reproduce it?

See demo video here

Grafana OnCall Version

v1.3.80

Product Area

Other

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response

joeyorlando avatar Dec 19 '23 13:12 joeyorlando

@joeyorlando it displays a red border because the value must be a multiple of 5 (see minuteStep param), should we disable this restriction, WDYT?

maskin25 avatar Jan 10 '24 15:01 maskin25

@maskin25 ohhh interesting. wonder if it's worthwhile adding a small note about that? (or at least giving validation feedback as to why the input is red/invalid).

joeyorlando avatar Jan 10 '24 15:01 joeyorlando

@joeyorlando FYI after discussion with @raphael-batte we decided to get rid of this restriction, will do this in the next iteration

maskin25 avatar Jan 17 '24 13:01 maskin25

closing as completed in #3659

joeyorlando avatar Mar 06 '24 11:03 joeyorlando