mimir
mimir copied to clipboard
helm: Do not render empty fields (subPath, args, env & envFrom)
What this PR does
Many fields in the mimir-distributed helm chart are templated, even if no values are specified. This PR should fix these.
Checklist
- [ ] Tests updated.
- [ ] Documentation added.
- [x]
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. - [ ]
about-versioning.mdupdated with experimental features.
@dimitarvdimitrov I'm not sure how to proceed from here.
I've ran make build-helm-tests and pushed a new commit, but since upstream was already updated there is a conflict.
What's the best approach?
we don't have strict git instructions. But what I'd do is
- squash your 4 commits into 1 (
git rebase -i HEAD~4and then mark all of them asfors) - make sure your local
upstream:mainref is up to date - rebase onto
upstream:main - force-push to
adberger:main
@dimitarvdimitrov I tried my best, can you rerun the tests?
Apologies, I gave it another try.