mimir icon indicating copy to clipboard operation
mimir copied to clipboard

helm: Do not render empty fields (subPath, args, env & envFrom)

Open adberger opened this issue 1 year ago • 5 comments

What this PR does

Many fields in the mimir-distributed helm chart are templated, even if no values are specified. This PR should fix these.

Checklist

  • [ ] Tests updated.
  • [ ] Documentation added.
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [ ] about-versioning.md updated with experimental features.

adberger avatar Mar 11 '24 16:03 adberger

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 11 '24 16:03 CLAassistant

@dimitarvdimitrov I'm not sure how to proceed from here.
I've ran make build-helm-tests and pushed a new commit, but since upstream was already updated there is a conflict. What's the best approach?

adberger avatar Mar 15 '24 12:03 adberger

we don't have strict git instructions. But what I'd do is

  1. squash your 4 commits into 1 (git rebase -i HEAD~4 and then mark all of them as f or s)
  2. make sure your local upstream:main ref is up to date
  3. rebase onto upstream:main
  4. force-push to adberger:main

dimitarvdimitrov avatar Mar 15 '24 13:03 dimitarvdimitrov

@dimitarvdimitrov I tried my best, can you rerun the tests?

adberger avatar Mar 15 '24 14:03 adberger

Apologies, I gave it another try.

adberger avatar Mar 16 '24 08:03 adberger