mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Published 20 hours ago • verified publisher icon grafana

S3 multipart enchancement

Open fatpat opened this issue 1 year ago • 4 comments

What this PR does

Allow to disable multipart uploads in storage provider and in tools and to configure part size in tools.

note: a PR has been submitted to thanos-io/objstore (https://github.com/thanos-io/objstore/pull/100) to add DisableMultipart option. I've backport the patch manually in vendor/ while waiting for this PR to be merged.

Checklist

  • [ ] Tests updated.
  • [ ] Documentation added.
  • [X] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [ ] about-versioning.md updated with experimental features.

fatpat avatar Feb 10 '24 08:02 fatpat

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 10 '24 08:02 CLAassistant

Thanks for the PR! I've converted it to a draft until the upstream Thanos objstore PR is merged.

56quarters avatar Feb 21 '24 17:02 56quarters

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

duricanikolic avatar Mar 12 '24 09:03 duricanikolic

Thanks for the PR! I've converted it to a draft until the upstream Thanos objstore PR is merged.

upstream PR has been merged and updated in mimir modules.

I put the PR as ready to review

fatpat avatar May 13 '24 12:05 fatpat