mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Published 20 hours ago • verified publisher icon grafana

6964 mimir istio fixes

Open Paul424 opened this issue 1 year ago • 5 comments

What this PR does

Solves networking issues when running mimir injected (istio). Following issue's are addressed:

  1. When query_scheduler is enabled the helm chart does not render the headless service for the query-frontend, but istio needs it to register the (headless) svc route that the querier is using to report back query results.
  2. When memcached is enabled the svc cannot connect to the caches because the port naming prevent istio to do proper protocol selection.
  3. grpc ports do need appProtocol setting to make sure istio selects the correct protocol.

Which issue(s) this PR fixes or relates to

Fixes #6964

Checklist

  • [ ] Tests updated.
  • [ ] Documentation added.
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [ ] about-versioning.md updated with experimental features.

Paul424 avatar Dec 19 '23 16:12 Paul424

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 19 '23 16:12 CLAassistant

The CI seems to be failing. The lint-jsonnet step is failing because the rendered kubernetes manifests for jsonnet haven't been updated. You can do that with make build-jsonnet-tests

However, lint-helm seems to be failing with some helm templating issue. I can reproduce the failure locally with running make build-helm-tests. After fixing them you should rerun that command and commit the diff.

dimitarvdimitrov avatar Jan 02 '24 17:01 dimitarvdimitrov

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

duricanikolic avatar Mar 12 '24 09:03 duricanikolic

@Paul424 Are you able to clean up this MR according to the requests so this is able to get merged? Having better istio support we be a great feature to have and I and I'm sure many others look forward to getting this merged in and having it available

nbjohnson avatar Mar 26 '24 13:03 nbjohnson

@nbjohnson I would love to, but I no longer have access to the dev/env I used to work on this PR. Give me some time to setup a new environment... or if someone else wants to fork and complete the PR? fine for me. Paul

Paul424 avatar Mar 26 '24 19:03 Paul424