mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Support the type param in /api/v1/rules endpoint

Open FUSAKLA opened this issue 2 years ago • 1 comments

Mimir implements the /api/v1/rules endpoint, but does not support the documented type=alert|record query parameter

see https://prometheus.io/docs/prometheus/latest/querying/api/#rules

Should be easy to implement here, the question is if that would be a change in API now or just additional functionality/bugfix

FUSAKLA avatar Feb 20 '23 23:02 FUSAKLA

the question is if that would be a change in API now or just additional functionality/bugfix

I don't think would be a breaking change, because if the parameter is not specified then no filtering will happen. So, I would consider it a bugfix, given this API endpoint is expected be Prometheus-compatible.

pracucci avatar Feb 23 '23 17:02 pracucci