mimir icon indicating copy to clipboard operation
mimir copied to clipboard
verified publisher icon grafana

[otlp] Update OTel Collector PRW translate package to 0.71.0

Open kovrus opened this issue 2 years ago • 4 comments

What this PR does

Updates the OTel Collector PRW translate package to 0.71.0. The PR contains the following user-facing changes:

  • Add support for converting OTLP Exponential Histograms to Prometheus Native Histograms.
  • Export _created metric for Summary, Histogram, and Monotonic Sum metric points if StartTimeUnixNano is set. It is disabled by default, the configuration parameter can be exposed in the future.
  • Do not drop exemplars of the OTLP Monotonic Sum metric.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • [x] Tests updated
  • [ ] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

kovrus avatar Jan 24 '23 11:01 kovrus

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 24 '23 11:01 CLAassistant

Can you update the end to end test to include an exponential histogram?

gouthamve avatar Jan 24 '23 12:01 gouthamve

Please also remember to sign the CLA. Thanks!

pracucci avatar Jan 24 '23 13:01 pracucci

Can you please take a look at PR again? I've added a simple test case https://github.com/grafana/mimir/pull/4063/files#diff-57b597f7e1c988306aeac3c21175be693dd901c035761195212f24ca0a4a96b6R79 and updated the change log. (sorry, squashed the commits with addressing the feedback)

kovrus avatar Feb 17 '23 15:02 kovrus

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

pstibrany avatar Mar 09 '23 09:03 pstibrany

@kovrus Any update on this PR?

pracucci avatar Mar 09 '23 09:03 pracucci

@pracucci didn't have a chance to work on it. I'll implement the missing mimir to prom ts conversion today or tomorrow.

kovrus avatar Mar 09 '23 11:03 kovrus

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

Under ## main / unreleased or ### Grafana Mimir?

kovrus avatar Mar 10 '23 14:03 kovrus

@pracucci @pstibrany can you take another look?

kovrus avatar Mar 15 '23 16:03 kovrus

kovrus requested a review from pstibrany

Just FYI: waiting for updated integration test that queries native histograms back after ingesting them.

pstibrany avatar Mar 20 '23 13:03 pstibrany

kovrus requested a review from pstibrany

Just FYI: waiting for updated integration test that queries native histograms back after ingesting them.

updated

kovrus avatar Mar 22 '23 08:03 kovrus