mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Enable adding extra k8s resources to helm chart via values

Open jamesross3 opened this issue 2 years ago • 3 comments

What this PR does

Originally here: https://github.com/grafana/mimir/pull/3956 Created a new PR after correcting local git config so that the license/cla check passes.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • [x] Tests updated
  • [x] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

jamesross3 avatar Jan 17 '23 22:01 jamesross3

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

56quarters avatar Jan 20 '23 14:01 56quarters

thanks @dimitarvdimitrov! updated

jamesross3 avatar Jan 20 '23 15:01 jamesross3

hey, I'm afraid this PR now has unintended changes. Maybe these got in during the rebase

Screenshot 2023-01-24 at 11 09 21

I also see a conflict with the changelog because I think the 2.6 Mimir release was cut. Could you look into that?

dimitarvdimitrov avatar Jan 24 '23 10:01 dimitarvdimitrov

sorry @dimitarvdimitrov but replacing this again since I've messed up the commit history - see https://github.com/grafana/mimir/pull/4102 instead

jamesross3 avatar Jan 27 '23 21:01 jamesross3