mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Use built-in alertmanager config if no fallback config is provided

Open JohnnyQQQQ opened this issue 3 years ago • 4 comments

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #2772

Checklist

  • [x] Tests updated
  • [x] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

JohnnyQQQQ avatar Nov 28 '22 14:11 JohnnyQQQQ

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 28 '22 14:11 CLAassistant

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

replay avatar Nov 29 '22 14:11 replay

There is also one in the integration folder, which is not failing correctly. I'm investigating it.

JohnnyQQQQ avatar Jan 17 '23 11:01 JohnnyQQQQ

The thing was that the mock that we are using in the test was built manually and not using the constructor, thus no fallback config was computed. I fixed that here, and now everything works as expected. The tests were failing and I rewrote them to reflect those changes and check for the default config instead of a 412 after a deletion. For the frontend tests the expected behavior is a redirect instead of a 412 after deletion, as the fallback config is used.

JohnnyQQQQ avatar Jan 20 '23 12:01 JohnnyQQQQ

Nice job, thanks!

pracucci avatar Jan 31 '23 15:01 pracucci