mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Add -usage-stats.installation-mode configuration to track the installation mode

Open 0xPoe opened this issue 3 years ago • 1 comments

What this PR does

  • Add -usage-stats.installation-mode configuration to track the installation mode.
  • Update helm and jsonnet templates.

Which issue(s) this PR fixes or relates to

Fixes https://github.com/grafana/mimir/issues/3149

Checklist

  • [x] Tests updated
  • [x] Documentation added
  • [ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

0xPoe avatar Oct 18 '22 03:10 0xPoe

Should this be in draft mode, or is it ready for review?

aknuds1 avatar Oct 18 '22 06:10 aknuds1

Next step is to add it to jsonnet and helm, but I'm happy if you follow up with separate PRs.

Thanks for your review. I also prefer to update it in the next PR because I need more time to update both the helm and the jsonnet templates.

0xPoe avatar Oct 18 '22 13:10 0xPoe

Next step is to add it to jsonnet and helm, but I'm happy if you follow up with separate PRs.

Thanks for your review. I also prefer to update it in the next PR because I need more time to update both the helm and the jsonnet templates.

I think for helm it would make sense to add it as a CLI flag on all components and not part of the YAML config template. Since there would be no need to change it, doesn't affect how metrics are handled and makes it hard to overwrite by accident.

krajorama avatar Oct 18 '22 14:10 krajorama

@hi-rustin Are you going to take care of adding the CLI flag to jsonnet and Helm, or should we delegate to someone else?

pracucci avatar Oct 19 '22 06:10 pracucci

Oh, I almost forgot. Please add an entry to docs/sources/operators-guide/configure/about-anonymous-usage-statistics-reporting.md to mention we're tracking the installation mode as well. In the section "Which information is collected", I would add a new entry under "Information about the Mimir cluster and version", something like "- The installation mode used to deploy Mimir, such as helm.".

pracucci avatar Oct 19 '22 06:10 pracucci

Are you going to take care of adding the CLI flag to jsonnet and Helm, or should we delegate to someone else?

I'll take care it.

0xPoe avatar Oct 19 '22 07:10 0xPoe