mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Make api prefix configurable in mimirtool

Open chrisevett opened this issue 2 years ago • 5 comments

What this PR does

Makes prometheus api prefix configurable in mimir tool to match mimir API and helm chart

Which issue(s) this PR fixes or relates to

Fixes #2917

Checklist

  • [x] Tests updated
  • [x] Documentation added
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

chrisevett avatar Sep 08 '22 04:09 chrisevett

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 08 '22 04:09 CLAassistant

The lint failure looks like generated docs need to be updated via make docs

56quarters avatar Sep 08 '22 15:09 56quarters

@dimitarvdimitrov think I addressed your suggestions if you could take a second look. Thanks!

chrisevett avatar Sep 13 '22 03:09 chrisevett

@dimitarvdimitrov ready for you to take another look if you please

chrisevett avatar Sep 15 '22 15:09 chrisevett

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

pracucci avatar Oct 07 '22 09:10 pracucci

@chrisevett 👋 Hi Chris! We would love to move forward with this work. Have you got a chance to look at Dimitar's comments?

pracucci avatar Nov 03 '22 10:11 pracucci

@chrisevett Was this PR intentionally closed?

pracucci avatar Jan 03 '23 13:01 pracucci