mimir icon indicating copy to clipboard operation
mimir copied to clipboard

Published 20 hours ago • verified publisher icon grafana

distributor: remove labels with empty values

Open bboreham opened this issue 3 years ago • 1 comments

Empty labels are stripped when the series reaches TSDB, so we should remove them earlier to keep things consistent.

Checklist

  • [x] Tests updated
  • NA Documentation added - this is not user-visible; we are just stripping them earlier.
  • [x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

bboreham avatar Jul 15 '22 17:07 bboreham

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

pracucci avatar Oct 07 '22 09:10 pracucci

Rebased against latest main; reworded the test to use labels.FromStrings().

bboreham avatar Dec 06 '22 09:12 bboreham