mimir
mimir copied to clipboard
helm: do not render `PodSecurityPolicy` manifest on gke >= 1.25
Signed-off-by: Miguel Ángel Ortuño [email protected]
What this PR does
PodSecurityPolicy
resource will be completely removed from GKE in the future. This PR prevents it from being rendered on versions greater than 1.25.
Which issue(s) this PR fixes or relates to
Fixes N/A
Checklist
- [X] Tests updated
- [ ] Documentation added
- [ ]
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
I'd err on the side of letting kubernetes reject the deprecated object. It's immediate feedback after running helm install
or helm upgrade
compared to silently the chart swallowing the incompatibility.
actually I think we should migrate to the pod admission controller instead of doing anything with the pod security policy
after reading a bit, it turns out that this approach is actually the preferred one. I made another similar PR https://github.com/grafana/mimir/pull/2870
@krajorama did you try with the changes in https://github.com/grafana/mimir/pull/2870?
@krajorama did you try with the changes in #2870?
Testing