loki icon indicating copy to clipboard operation
loki copied to clipboard

Loki config to see also runtime configuration

Open BaskiGIT opened this issue 1 year ago • 2 comments

Description /config of Loki read and write targets usually show the entire config used by Loki. However the fields set with runtime configuration do not appear with /config endpoint

Steps to Reproduce

  1. Bring up Loki with simple scalable mode of read and write; Inject runtime configuration for "deletion_mode: disabled"
  2. Hit /config of either read and write targets endpoint
  3. Search for deletion_mode text

Expected behavior "deletion_mode" under limits_config is supposed to contain disabled but still the default value of "filter-and-delete" is present

Environment:

  • GKE
  • kustomize
  • Loki version 2.8.2

Screenshots image

BaskiGIT avatar Jun 26 '23 14:06 BaskiGIT

I have also encountered this unexpected behaviour using kubernetes helm chart 5.15.0 (loki version 2.8.4) and using loki as a single instance. Setting retention_period in runtime configuration seems to work fine (older records are deleted) but config endpoint does not honor it.

doganyazar avatar Aug 28 '23 13:08 doganyazar

the config should reflect the entire config including runtimes or create a new endpoint for runtime like mimir has /runtime_config

gespi1 avatar Apr 30 '24 17:04 gespi1

is there a way to configure the runtime config in the values.yaml file or generally how its configured. I can see in the pods /etc/loki/runtime_config but its empty

mehransaeed7810 avatar Aug 15 '24 14:08 mehransaeed7810